fix: do not pass --{enable,disable}-features twice when user-provided #11230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Oct 23, 2023
thiagowfx
force-pushed
the
thiagowfx/features
branch
from
2f0b4a4
to
767523c
Compare
Lightning00Blade
approved these changes
Oct 23, 2023
thiagowfx
force-pushed
the
thiagowfx/features
branch
from
7412e29
to
17e08ee
Compare
Currently, whenever the user provides:
args: '--disable-features=TestDisableFeatures'
The --disable-features flag appears twice in chrome arguments.
Make it appear only once, by merging them.
Ditto for --enable-features.
Bug: #11208
thiagowfx
force-pushed
the
thiagowfx/features
branch
from
17e08ee
to
a76c1d2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever the user provides:
The --disable-features flag appears twice in chrome arguments.
Make it appear only once, by merging them.
Ditto for --enable-features.
Fixed: #11208