New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove legacy checks in keyboard tests #10995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
3 times, most recently
from
September 22, 2023 10:15
921a137
to
79e3e98
Compare
jrandolf
force-pushed
the
jrandolf/fix-allow-viewport-expansion
branch
from
September 22, 2023 10:22
c68fc84
to
e34afb8
Compare
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
3 times, most recently
from
September 22, 2023 10:34
3b2a181
to
4def96e
Compare
jrandolf
force-pushed
the
jrandolf/fix-allow-viewport-expansion
branch
from
September 22, 2023 10:52
e34afb8
to
f333db2
Compare
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
from
September 22, 2023 10:53
4def96e
to
2378f83
Compare
jrandolf
force-pushed
the
jrandolf/fix-allow-viewport-expansion
branch
2 times, most recently
from
September 22, 2023 11:12
c3d0ebc
to
325aff4
Compare
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
3 times, most recently
from
September 22, 2023 11:15
e827ca8
to
dee3c60
Compare
jrandolf
force-pushed
the
jrandolf/fix-allow-viewport-expansion
branch
from
September 22, 2023 11:20
325aff4
to
6e7d39c
Compare
OrKoN
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff shows unrelated changes and merge conflicts.
Base automatically changed from
jrandolf/fix-allow-viewport-expansion
to
main
September 22, 2023 11:48
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
2 times, most recently
from
September 22, 2023 11:54
e762d9c
to
d4da463
Compare
OrKoN
approved these changes
Sep 22, 2023
jrandolf
force-pushed
the
jrandolf/fix-keyboard-test
branch
from
September 22, 2023 12:22
d4da463
to
af80ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #10950