Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement mapHandle and filterHandle #10716

Merged
merged 1 commit into from Aug 9, 2023
Merged

chore: implement mapHandle and filterHandle #10716

merged 1 commit into from Aug 9, 2023

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented Aug 9, 2023

No description provided.

@jrandolf jrandolf requested a review from OrKoN August 9, 2023 14:06
OrKoN
OrKoN reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add tests

@jrandolf
Copy link
Contributor Author

jrandolf commented Aug 9, 2023

let's add tests

The current tests are sufficient since the filter proxies filterHandle

@jrandolf jrandolf enabled auto-merge (squash) August 9, 2023 14:14
@jrandolf jrandolf requested a review from OrKoN August 9, 2023 14:17
@jrandolf jrandolf merged commit 0c59e9a into main Aug 9, 2023
30 checks passed
@jrandolf jrandolf deleted the jrandolf/locator-all branch August 9, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrandolf @OrKoN