fix: clear pending TLS socket handle #10667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I recognised when calling
canDownload
the@puppeteer/browsers
package makes aHEAD
request, e.g. tohttps://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/116.0.5793.0/mac-arm64/chrome-mac-arm64.zip
. This causes the Node.js process to stale as there stay pendingTLSSocket
aroundDid you add tests for your changes?
I am currently working on webdriverio/webdriverio#10767 and have been encountered this issue. Adding given code line resolves it.
My current workaround is:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
I don't think so.
Other information