Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement partial ElementHandle.prototype.boundingBox #10660

Merged
merged 1 commit into from
Aug 1, 2023
Merged

chore: implement partial ElementHandle.prototype.boundingBox #10660

merged 1 commit into from
Aug 1, 2023

Conversation

jrandolf
Copy link
Contributor

No description provided.

@jrandolf jrandolf requested review from OrKoN and Lightning00Blade and removed request for OrKoN July 28, 2023 13:04
OrKoN
OrKoN reviewed Jul 28, 2023
View reviewed changes
test/TestExpectations.json Outdated Show resolved Hide resolved
@jrandolf jrandolf requested a review from OrKoN July 28, 2023 13:33
OrKoN
OrKoN approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % tests pass

consider integrating sandboxes via this.frame.isolatedRealm().evaluate()

@jrandolf jrandolf force-pushed the jrandolf/bounding-box branch 2 times, most recently from 54057a2 to 3eeb94a Compare July 31, 2023 08:56
@jrandolf jrandolf force-pushed the jrandolf/bounding-box branch 2 times, most recently from 1141110 to 71e89c1 Compare August 1, 2023 13:07
@jrandolf jrandolf merged commit 04369db into main Aug 1, 2023
2 checks passed
@jrandolf jrandolf deleted the jrandolf/bounding-box branch August 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrandolf @OrKoN @Lightning00Blade