feat: add page.createCDPSession method #10515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/cdp-session-bidi
branch
2 times, most recently
from
72fc170
to
ee95f3f
Compare
OrKoN
force-pushed
the
orkon/cdp-session-bidi
branch
from
ee95f3f
to
8297d57
Compare
OrKoN
force-pushed
the
orkon/cdp-session-bidi
branch
2 times, most recently
from
ee1f3a0
to
6137894
Compare
OrKoN
force-pushed
the
orkon/cdp-session-bidi
branch
from
6137894
to
b4a44f6
Compare
| @@ -622,6 +623,13 @@ export class Page extends EventEmitter { | |||
| throw new Error('Not implemented'); | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a Chrome Devtools Protocol session attached to the page. | |||
There was a problem hiding this comment.
Nit: Link to CDP website?
OrKoN
commented
Jul 21, 2023
Lightning00Blade
approved these changes
Jul 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no particular reason why a CDP session should be created only through the targets. Since we are not sure if the target API makes sense for a WebDriver BiDi client, I think it makes sense to expose a shortcut via the page (in the future, frame and worker instances too).