Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: negative timeout doesn't break launch #10480

Merged
merged 1 commit into from Jun 29, 2023
Merged

fix: negative timeout doesn't break launch #10480

merged 1 commit into from Jun 29, 2023

Conversation

Lightning00Blade
Copy link
Collaborator

No description provided.

jrandolf
jrandolf suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@jrandolf jrandolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to throw here if it is negative too.

@OrKoN OrKoN changed the title fix: negative timeout doesn't brake launch fix: negative timeout doesn't break launch Jun 29, 2023
@Lightning00Blade Lightning00Blade merged commit 6a89a2a into main Jun 29, 2023
19 checks passed
@Lightning00Blade Lightning00Blade deleted the fix-browsers-timeout branch June 29, 2023 15:34
@release-please release-please bot mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@jrandolf jrandolf jrandolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lightning00Blade @OrKoN @jrandolf