chore: support Tab targets #10148
Merged
chore: support Tab targets #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/tab
branch
13 times, most recently
from
14e54ba
to
0a4e19e
Compare
OrKoN
force-pushed
the
orkon/tab
branch
3 times, most recently
from
a005c92
to
d5e5796
Compare
OrKoN
force-pushed
the
orkon/tab
branch
8 times, most recently
from
a897e67
to
ba3c0f4
Compare
OrKoN
force-pushed
the
orkon/tab
branch
2 times, most recently
from
96734c6
to
95599b1
Compare
Lightning00Blade
approved these changes
Aug 21, 2023
OrKoN
force-pushed
the
orkon/tab
branch
3 times, most recently
from
2ec6fcd
to
c641798
Compare
OrKoN
force-pushed
the
orkon/tab
branch
2 times, most recently
from
3e1bab4
to
b1eae87
Compare
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab target is a new type of target in CDP that reflects the architectural changes in Chromium that were needed for features such as bfcache, portal and prerendering.
Previously, the
pagetargets were the top-level targets representing the entire tab. If you navigate to a new URL, the page target would remain the same. With the introduction of thetabtarget, it's not possible to have multiple page targets active within one tab. For example, one page would be the currently shown page and the other one would be a prerendered page. When the user navigates to the prerendered page, the secondary page becomes the primary and the primary page target gets destroyed (the process is called activation).Puppeteer does not support this interaction so this PR disabled the prerendering feature in addition to the previously disabled bfcache.
This change adds support for the tab target behind the flag. Currently, we don't plan on exposing the
tabtarget via the Puppeteer API and aim at keeping it an implementation detail. The support for the tab target is also limited for now: we support the target activation but the tracing/network/a11y/coverage might not work as expected if the activation happens. We will aim at improving it in the future. For the scenarios, where no activation happens there should be no difference between the tab target and non-tab target modes.The current level of support is relatively basic: emulation/tracing/coverage might not work as expected if an activation happens. We will enable the tab mode by default once the emulation/tracing/coverage is handled in a solid way.
Issue #10147