New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename PUPPETEER_DOWNLOAD_HOST to PUPPETEER_DOWNLOAD_BASE_URL #10130
Conversation
4bf1258
to
fa8a5c8
Compare
Can we deprecate then remove in a later release? |
Thinking a bit more, let’s hold off with this and I will add a deprecation warning for the download host |
440452a
to
03503fd
Compare
Change to Chrome for Testing changed the servers we download binaries from so PUPPETEER_DOWNLOAD_HOST would not work as it used to because the rest of the file structure changed too. This change documents the breaking change and removes the PUPPETEER_DOWNLOAD_HOST in favour of PUPPETEER_DOWNLOAD_BASE_URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this will push Browsers to 1.0.1
due to the Change being a fix.
Only docs were changed for Browsers, something to keep in mind
The switch to Chrome for Testing changed the servers we download binaries from so PUPPETEER_DOWNLOAD_HOST would not work as it used to because the rest of the URL structure changed too. This change documents the change and deprecates the PUPPETEER_DOWNLOAD_HOST in favour of PUPPETEER_DOWNLOAD_BASE_URL.
Closes #10131