fix: added clipboard permission that was not exposed #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have a test? |
Lightning00Blade
changed the title
|
Hi guys, thank you for taking a look into this! I just wanted to say that if you want a test for this specific Chrome Extension problem then you can try use this setup. |
|
hey, can any maintainer please provide a timeline in which this change will be merged? |
Lightning00Blade
force-pushed
the
unblock-clipboard-issue
branch
from
1131c42
to
d7fe52c
Compare
OrKoN
approved these changes
Jun 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10103
Closes #10211
Did not investigate further on what the differences are but passing this Permission work. A quick search also suggest passing this CDP Permission when dealing with clipboard.
https://tinyurl.com/raw-clipboard-access-design