Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement detailed errors for evaluation #10114

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented May 2, 2023

This PR allows users to know the exact location their client-side scripts may be throwing.

Note this assumes we are running on V8 where Error.prepareStackTrace exists.

@jrandolf jrandolf force-pushed the jrandolf/detailed-errors branch 9 times, most recently from badea62 to 134d2c2 Compare May 5, 2023 10:48
@jrandolf jrandolf requested a review from OrKoN May 5, 2023 10:48
@jrandolf jrandolf force-pushed the jrandolf/detailed-errors branch 4 times, most recently from 7096dfd to 4f3d0c8 Compare May 8, 2023 13:15
@OrKoN OrKoN force-pushed the jrandolf/detailed-errors branch from 4f3d0c8 to 8ac39cc Compare May 8, 2023 13:20
@OrKoN OrKoN added the devtools label May 8, 2023
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be failing, otherwise LGTM.

packages/puppeteer-core/src/common/util.ts Show resolved Hide resolved
@jrandolf jrandolf force-pushed the jrandolf/detailed-errors branch 8 times, most recently from fd7dd91 to c954d18 Compare May 9, 2023 16:11
This PR allows users to know the exact location their client-side scripts may be throwing.

Note this assumes we are running on Node.js where `Error.prepareStackTrace` exists.
@jrandolf jrandolf enabled auto-merge (squash) May 9, 2023 21:30
@jrandolf jrandolf merged commit 317fa73 into main May 10, 2023
30 checks passed
@jrandolf jrandolf deleted the jrandolf/detailed-errors branch May 10, 2023 08:23
@release-please release-please bot mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants