fix: infer last pressed button in mouse move #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Apr 24, 2023
OrKoN
requested changes
Apr 24, 2023
jrandolf
force-pushed
the
jrandolf/fix-mouse
branch
from
59dbfe7
to
aebaee6
Compare
jrandolf
changed the title
none for mouse move
jrandolf
force-pushed
the
jrandolf/fix-mouse
branch
from
aebaee6
to
f970a15
Compare
jrandolf
force-pushed
the
jrandolf/fix-mouse
branch
from
f970a15
to
ecfbbad
Compare
OrKoN
approved these changes
Apr 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mouse move event requires the "last pressed" button. For example, see https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/input/synthetic_mouse_driver.cc;l=101;bpv=0;bpt=1 and https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/renderer_host/input/web_input_event_builders_mac.mm;drc=a61b95c63b0b75c1cfe872d9c8cdf927c226046e;bpv=1;bpt=1;l=221
More precisely, we need to use the mouse button with the lowest flag value. The reason is not clear, however it's assumed there is internal state that requires the mouse move event to match the latest pressed event.