feat: add warn for headless: true
#10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Apr 18, 2023
OrKoN
reviewed
Apr 18, 2023
Lightning00Blade
force-pushed
the
depracate-old-headless
branch
2 times, most recently
from
6134889
to
1bf5732
Compare
Lightning00Blade
force-pushed
the
depracate-old-headless
branch
from
1bf5732
to
316813e
Compare
OrKoN
force-pushed
the
depracate-old-headless
branch
from
64d421e
to
cf7afa9
Compare
|
let's mark it as a feat to make it show up in the changelog |
Lightning00Blade
changed the title
headless: trueheadless: true
Lightning00Blade
force-pushed
the
depracate-old-headless
branch
2 times, most recently
from
58df0d1
to
8643fc6
Compare
OrKoN
approved these changes
Apr 20, 2023
OrKoN
force-pushed
the
depracate-old-headless
branch
from
507b188
to
71ea655
Compare
Lightning00Blade
force-pushed
the
depracate-old-headless
branch
from
71ea655
to
6342498
Compare
OrKoN
force-pushed
the
depracate-old-headless
branch
from
6342498
to
0f9361a
Compare
DEPRECATION: `puppeteer.launch({headless: true})`
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Lightning00Blade
force-pushed
the
depracate-old-headless
branch
from
0f9361a
to
b6099cb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn for future behavior change of
puppeteer.launch({headless: true})The message can be suppressed by setting:
Env -
PUPPETEER_DISABLE_HEADLESS_WARNING=true, (or via general loggingPUPPETEER_LOGLEVEL=silent,PUPPETEER_LOGLEVEL=error,)Config -
logLevel: 'silent',logLevel: 'error'NPM LogLevel - https://docs.npmjs.com/cli/v9/using-npm/logging (
silentorerror)Warning:
