feat: support AbortController in waitForSelector #10018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/abort-controller
branch
2 times, most recently
from
530b831
to
07ae04e
Compare
|
I guess we can ship it since it is an optional feature and AbortController can be enabled on Node 14. |
OrKoN
force-pushed
the
orkon/abort-controller
branch
from
07ae04e
to
4e1f68e
Compare
jrandolf
approved these changes
Apr 13, 2023
OrKoN
force-pushed
the
orkon/abort-controller
branch
from
4e1f68e
to
226bfb6
Compare
OrKoN
force-pushed
the
orkon/abort-controller
branch
from
226bfb6
to
723d4e0
Compare
This was referenced Apr 18, 2023
Closed
Merged
|
Hey, thanks for this great addition! |
|
That has been already addressed in #10048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9709