Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement locators with a click #10009

Merged
merged 3 commits into from May 5, 2023
Merged

chore: implement locators with a click #10009

merged 3 commits into from May 5, 2023

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 12, 2023 •
edited

This PR implements a locator API and a click operation. The click is automatically retried and the following pre-conditions are checked automatically:

      1. ensureElementIsInTheViewport
      2. waitForVisibility
      3. waitForEnabled
      4. waitForStableBoundingBox

All scheduled tasks can aborted using AbortController.

The API is not public and I think we should make it public once we have at least a few other actions.

@OrKoN OrKoN force-pushed the orkon/locators branch 9 times, most recently from fa87339 to 554e1fd Compare April 18, 2023 09:43
@OrKoN OrKoN force-pushed the orkon/locators branch 3 times, most recently from e25a3e8 to d0cbbf6 Compare April 25, 2023 15:50
@OrKoN OrKoN changed the title chore: wip locators chore: implement locators with a click Apr 27, 2023
@OrKoN OrKoN marked this pull request as ready for review April 27, 2023 10:45
jrandolf
jrandolf suggested changes Apr 27, 2023
View reviewed changes
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
Lightning00Blade
Lightning00Blade requested changes Apr 27, 2023
View reviewed changes
packages/puppeteer-core/src/api/Locator.ts Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
test/src/locator.spec.ts Outdated Show resolved Hide resolved
test/src/locator.spec.ts Outdated Show resolved Hide resolved
test/src/locator.spec.ts Outdated Show resolved Hide resolved
test/src/locator.spec.ts Outdated Show resolved Hide resolved
packages/puppeteer-core/src/api/Locator.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN force-pushed the orkon/locators branch 3 times, most recently from 9577115 to d755e7e Compare April 27, 2023 15:13
Lightning00Blade
Lightning00Blade approved these changes May 4, 2023
View reviewed changes
test/src/locator.spec.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN enabled auto-merge (squash) May 5, 2023 07:46
OrKoN and others added 3 commits May 5, 2023 10:33
@OrKoN OrKoN merged commit 9a1aff8 into main May 5, 2023
30 checks passed
@OrKoN OrKoN deleted the orkon/locators branch May 5, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

@jrandolf jrandolf jrandolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrKoN @Lightning00Blade @jrandolf