fix: prevent erroneous new main frame (#10549)

adamraine · web-flow · commit cb46413d87f1 · 2023-07-13T22:11:36.000+02:00
diff --git a/packages/puppeteer-core/src/common/FrameTree.ts b/packages/puppeteer-core/src/common/FrameTree.ts
@@ -69,7 +69,7 @@ export class FrameTree<Frame extends BaseFrame> {
         this.#childIds.set(frame._parentId, new Set());
       }
       this.#childIds.get(frame._parentId)!.add(frame._id);
-    } else {
+    } else if (!this.#mainFrame) {
       this.#mainFrame = frame;
     }
     this.#waitRequests.get(frame._id)?.forEach(request => {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export class FrameTree<Frame extends BaseFrame> {`
`69`	`69`	`this.#childIds.set(frame._parentId, new Set());`
`70`	`70`	`}`
`71`	`71`	`this.#childIds.get(frame._parentId)!.add(frame._id);`
`72`		`- } else {`
	`72`	`+ } else if (!this.#mainFrame) {`
`73`	`73`	`this.#mainFrame = frame;`
`74`	`74`	`}`
`75`	`75`	`this.#waitRequests.get(frame._id)?.forEach(request => {`