-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #3282] idle-timeout
not waiting on all workers in cluster mode
#3283
[Fix #3282] idle-timeout
not waiting on all workers in cluster mode
#3283
Conversation
238a792
to
d32eb90
Compare
Not sure about the |
61b5160
to
6bede5c
Compare
f3a24dd
to
264ecf8
Compare
264ecf8
to
d0e4227
Compare
Thanks for working on this. I haven't reviewed all of it. One thing. We cannot change the method signature of |
That's fair, I'll update. Edit: Adressed in https://github.com/puma/puma/compare/df23fbf1a7d855f3158c2d3976592b6f5dfe7200..0749bd7dbe7ee655e0f86866a4a0dbe882b6c38b |
0749bd7
to
e90fe64
Compare
e90fe64
to
2bd0b49
Compare
connect | ||
10.times { | ||
fast_connect | ||
sleep 0.5 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Closes #3282
Ensures that the master process (and therefore the entire cluster) is only gracefully shut down when all workers have reached the idle timeout when in cluster mode, as opposed to any worker (current implementation).
Also adds a log to indicate that the idle time out has been reached in both modes
FWIW I've manually tested this against the Rails monolith I work on and it's looking good!
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.