Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl.rb - fix warn_if_in_single_mode when WEB_CONCURRENCY is set #3265

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

MSP-Greg
Copy link
Member

Description

Test fails on master...

Closes #3264

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg added the bug label Oct 24, 2023
@MSP-Greg MSP-Greg merged commit 85765b2 into puma:master Oct 25, 2023
62 of 64 checks passed
@MSP-Greg MSP-Greg deleted the 00-issue-3264 branch October 25, 2023 18:11
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
* test_integration_cluster.rb - add test_worker_hook_warning_web_concurrency

* dsl.rb - fix warn_if_in_single_mode for WEB_CONCURRENCY
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
* test_integration_cluster.rb - add test_worker_hook_warning_web_concurrency

* dsl.rb - fix warn_if_in_single_mode for WEB_CONCURRENCY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn_if_in_single_mode incorrectly triggers when WEB_CONCURRENCY >= 1
2 participants