[ci skip] | Docs | Clarify worker_timeout minimum value
#3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
clarify-worker-timeout-min-value
branch
from
d88bfa0
to
fd88328
Compare
joshuay03
changed the title
worker_timeout minimum valueworker_timeout minimum value
joshuay03
force-pushed
the
clarify-worker-timeout-min-value
branch
from
fd88328
to
f1de80c
Compare
|
Slight change to your wording but 👍 |
joshuay03
added a commit
to joshuay03/puma
that referenced
this pull request
Sep 26, 2023
* Docs | Clarify `worker_timeout` minimum value * Update dsl.rb --------- Co-authored-by: Nate Berkopec <nate.berkopec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When writing a test for #3225 I set the
worker_timeoutto be2sto avoid a test timeout. To do that, I needed to reduce theworker_check_intervalto1sto comply with this validation.However, the docs imply that the minimum
worker_timeoutcan only be6s, since it is greater than the defaultworker_check_intervalof5s.I've updated the docs to clarify that the minimum simply needs to comply with this validation, and removed any mention of a specific value as it can be infered from either the default
worker_check_intervalin the docs or the user configured value.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.