Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const.rb - Update Puma::HTTP_STATUS_CODES #3162

Merged
merged 2 commits into from May 23, 2023

Conversation

MSP-Greg
Copy link
Member

Description

Used code included in comments, which pulls info from the IANA Hypertext Transfer Protocol (HTTP) Status Code Registry.

Currently, test_puma_server.rb hard codes the strings in several tests, replaced with code using the hash values.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 2bb9143 into puma:master May 23, 2023
64 checks passed
@MSP-Greg
Copy link
Member Author

Thanks. AFK...

@MSP-Greg MSP-Greg deleted the 00-update-status-codes branch May 23, 2023 04:27
@koffeinfrei
Copy link

Shouldn't this have been be a breaking change? E.g. frontend code or automated tests relying on the status text need to be updated in order not to break.
This was part of a minor version release https://github.com/puma/puma/releases/tag/v6.3.0

@nateberkopec
Copy link
Member

We should've labeled this as a bug. Puma was serving the incorrect (or at least outdated) status text. We may fix bugs in any version release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants