Fixup req form data file upload with "r\n" line endings #3137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current code breaks when a form uploads a file with "\r\n" line endings.
Currently
client.rb
uses a string buffer that is initialized as UTF-8, it should be initialized as ASCII-8BIT. UTF-8 can be 'character/line-ending' sensitive, while ASCII-8BIT is just bytes...Add two tests, both with "\r\n" line endings, one as BOM|UTF-8.
Closes Discussion #3131
Running the two new tests on master has the below errors:
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.