Misc lib file fixes - trapping additional errors, CI helper #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
approved these changes
May 2, 2023
nateberkopec
reviewed
May 2, 2023
| @@ -48,7 +48,6 @@ def initialize(log_writer, conf = Configuration.new) | |||
|
|
|||
| @envs = {} | |||
| @ios = [] | |||
| localhost_authority | |||
There was a problem hiding this comment.
Yes. It's called early in the ssl section of parse. The call in the above section happens in initialize, so it's called regardless of whether an ssl bind is being used.
MSP-Greg
force-pushed
the
00-misc-lib-file-updates
branch
from
ae81065
to
b79e816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All files except
thread_pool.rbhave additional handling added. These errors have intermittently been seen in CI.thread_pool.rballows settingoptions[:pool_shutdown_grace_time]during CI, as stubbing a constant is difficult when running parallel CI. At present, it is not exposed via the DSL, but could be added in the future.Hence, no API or functionality changes.
These commits were originally part of PR #3128.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.