Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Modify test for PR #3118 #3119

Merged
merged 1 commit into from Apr 1, 2023
Merged

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Apr 1, 2023

Description

PR #3118 did not include a test, probably best to check for the issue.

This PR doesn't add a test, but modifies one. It raises NameError with #3118 reverted, as below:

  1) Error:
TestRackUp::TestOnBootedHandler#test_on_booted:
NameError: uninitialized constant Puma::Rack::CommonLogger
    /mnt/c/Greg/GitHub/puma/lib/rack/handler/puma.rb:35:in `block in config'
    /mnt/c/Greg/GitHub/puma/lib/puma/configuration.rb:195:in `configure'
    /mnt/c/Greg/GitHub/puma/lib/puma/configuration.rb:188:in `initialize'

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg added the bug label Apr 1, 2023
@MSP-Greg MSP-Greg mentioned this pull request Apr 1, 2023
7 tasks
@MSP-Greg MSP-Greg added CI / Testing and removed bug labels Apr 1, 2023
@MSP-Greg MSP-Greg merged commit f8e1fdf into puma:master Apr 1, 2023
63 checks passed
@MSP-Greg MSP-Greg deleted the 00-test-rack-handler branch April 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants