Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Delete ensure_pull_requests_are_labeled.yml workflow #3116

Merged
merged 1 commit into from Apr 1, 2023

Conversation

MSP-Greg
Copy link
Member

Description

Only maintainers can add PR labels, and this workflow runs for any PR changes. So, a contributor creates a PR and it fails on the first CI run.

Labels are used for generating our History/Changelog document. The labels 'security', 'feature', 'bug', 'perf', and 'refactor' are used to group commits, but many labels are not used in the document. Some labels are informative, like 'c-ext', 'ssl', and 'systemd', others are CI or test oriented...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 4f918a4 into puma:master Apr 1, 2023
62 of 63 checks passed
@MSP-Greg MSP-Greg deleted the 00-label-ci branch April 1, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants