Fix warn_if_in_single_mode incorrect message #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message could either be in the positive `but Puma is configured to run in single mode (worker count = 0 )` or the negative `but Puma is not configured to run in cluster mode (worker count > 0 )`. I went with negative because it explicitly instructs what is required in order for hooks to run.
Vuta
approved these changes
Mar 30, 2023
|
Whoops 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The message about hooks when in single mode is worded incorrectly. The message could either be in the positive
but Puma is configured to run in single mode (worker count = 0 )or the negativebut Puma is not configured to run in cluster mode (worker count > 0 ). I went with negative because it explicitly instructs what is required in order for hooks to run.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.