Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Log test retry information on workflow page #3103

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Mar 19, 2023

Description

The test suite currently runs with minitest-retry. Forty-seven (47) jobs are currently run against the test suite. Determining which tests were retried is very time consuming, as it involves opening the logs of each job and looking thru the test step log.

This PR adds logging the retried tests to the workflow summary page.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

The information may be removed sometime in the future, but the current 'Tests' workflow run with output is at the link below. You may need to scroll down on the right 'frame'...

https://github.com/puma/puma/actions/runs/4461555354

Copy link
Member

@nateberkopec nateberkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@MSP-Greg MSP-Greg merged commit 68f62d5 into puma:master Mar 27, 2023
@MSP-Greg MSP-Greg deleted the 00-log-retries branch March 27, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants