Warn when clustered-only hooks are defined in single mode #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vuta
commented
Feb 28, 2023
Vuta
force-pushed
the
warn_when_hooks_defined_in_single_mode
branch
from
a3cbbd9
to
b0ac31e
Compare
nateberkopec
requested changes
Mar 1, 2023
Vuta
force-pushed
the
warn_when_hooks_defined_in_single_mode
branch
from
b0ac31e
to
5d8afd4
Compare
…le mode Clustered-only hooks won't be called in single mode, so this commit adds a log to warn users about that. Also adds `silence_fork_callback_warning` option to opt-out of the default warning log.
Vuta
force-pushed
the
warn_when_hooks_defined_in_single_mode
branch
from
5d8afd4
to
4340f72
Compare
nateberkopec
approved these changes
Mar 6, 2023
|
Very nice 👏 |
jjb
reviewed
Oct 4, 2023
| if (@options[:workers] || 0) == 0 | ||
| log_string = | ||
| "Warning: You specified code to run in a `#{hook_name}` block, " \ | ||
| "but Puma is configured to run in cluster mode, " \ |
There was a problem hiding this comment.
this copy was fixed here: https://github.com/puma/puma/pull/3111/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address #2950
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.