Allow ::Rack::Handler::Puma.run to work regardless of whether Rack/Rackup are loaded #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
approved these changes
Feb 13, 2023
MSP-Greg
changed the title
|
Is it possible to get a |
|
turbo-rails is using Capybara & Puma 6.1.0 in their CI. See: https://github.com/hotwired/turbo-rails/actions/runs/4253429159/jobs/7398287552#step:3:131 Hence, is there more information you can give? EDIT: turbo-rails is using Rack 2, so never mind if you're using Rack 3. Not sure if that would work... |
|
It's from a private repo, but: |
|
But to be clear, this PR fixes the issue. It just hasn't been released to rubygems yet. |
nateberkopec
pushed a commit
that referenced
this pull request
Feb 28, 2023
…ckup are loaded (#3080) * rack/handler/puma.rb - fix for use without Rack * test/test_rack_handler.rb - add test for rackup bin file * test_rack_server.rb - only load needed Rack files * test_rack_handler.rb - remove Windows skip for test_bin
|
Done 👍 |
|
<3 you @nateberkopec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #3061 fixed the use of the
rackupbin file for use with either Rack 2 or Rack 3. It broke the use of::Rack::Handler::Puma.runwhen used stand-alone, which is used to start Puma in some CI frameworks.Fix the above issues, add a test for running the
rackupbin file usingIO.popen, which isolates it (and what it requires) from the main test process. Note that the test only runs on MRI Ruby, as non-MRI Rubies take time when usingIO.popen.The 'Tests' workflow uses the Rackup (includes the rackup bin) & Rack v3 gems, and the 'Rack_v2' workflow uses Rack v2 gem (includes the rackup bin).
See #2990 (comment)
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.