Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid request command: pumactl refork" #2866

Closed
slondr opened this issue Apr 28, 2022 · 1 comment · Fixed by #2868
Closed

"Invalid request command: pumactl refork" #2866

slondr opened this issue Apr 28, 2022 · 1 comment · Fixed by #2868
Labels

Comments

@slondr
Copy link

slondr commented Apr 28, 2022

Describe the bug
I run puma in refork mode, but when I run pumactl refork I just get:

Invalid request command: refork

refork does appear in the list of available commands when I run pumactl --help. Sending SIGURG to the main puma process works fine. Other pumactl commands, such as gc and stats, work fine.

Desktop (please complete the following information):

  • OS: Ubuntu Linux
  • Puma Version 5.5.0
@MSP-Greg
Copy link
Member

@slondr

Thanks for the report.

Looks like a bug that still exists in master. If one has a control url set, it won't send a refork signal. I think the line in the Puma::ControlCLI#run method:

if Puma.windows? || @control_url

Should be:

if Puma.windows? || @control_url && !NO_REQ_COMMANDS.include?(@command)

Haven't looked at a test yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants