Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniSSL - detect SSL_CTX_set_dh_auto #2864

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

MSP-Greg
Copy link
Member

Description

The link for SSL_CTX_set_dh_auto is at https://www.openssl.org/docs/man3.0/man3/SSL_CTX_set_dh_auto.html. But, it doesn't show links to other OpenSSL versions, which many functions do show.

It is defined for OpenSSL 1.1, so change to use function detection.

Closes #2863

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 6481347 into puma:master Apr 26, 2022
@MSP-Greg MSP-Greg deleted the 00-issue-2863-bsd branch April 26, 2022 01:54
nateberkopec pushed a commit that referenced this pull request Aug 22, 2022
Use SSL_CTX_set_dh_auto for all supported versions.  Previously, only used with OpenSSL 3.

Closes #2863
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Use SSL_CTX_set_dh_auto for all supported versions.  Previously, only used with OpenSSL 3.

Closes puma#2863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puma_http11 fails to build on OpenBSD 7.1
1 participant