-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail hard if SSL certs or keys cannot be read by user #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if an SSL cert or key could not be read, Puma would bind to the configured SSL port but not accept any connections. The only indication that something went awry is an obscure log message: ``` #<Puma::MiniSSL::SSLError: OpenSSL error: error:1417A0C1:SSL routines:tls_post_process_client_hello:no shared cipher - 193> ``` We now fail hard with an exception if this happens to make it clear that the permissions need to be fixed. Relates to puma#1339
Thanks for the PR, good catch/idea. Maybe add a method for file checking, something like: def check_file(file, desc)
raise ArgumentError, "#{desc} file '#{file}' does not exist" unless File.exist? file
raise ArgumentError, "#{desc} file '#{file}' is not readable" unless File.readable? file
end Also, perform the same update to the JRuby keystore file? See MSP-Greg@a254765, I can push the commit to your branch. |
Works for me! |
MSP-Greg
approved these changes
Mar 26, 2022
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Apr 3, 2022
* Fail hard if SSL certs or keys cannot be read by user Previously if an SSL cert or key could not be read, Puma would bind to the configured SSL port but not accept any connections. The only indication that something went awry is an obscure log message: ``` #<Puma::MiniSSL::SSLError: OpenSSL error: error:1417A0C1:SSL routines:tls_post_process_client_hello:no shared cipher - 193> ``` We now fail hard with an exception if this happens to make it clear that the permissions need to be fixed. Relates to puma#1339 * minissl.rb - add check_file method Co-authored-by: MSP-Greg <Greg.mpls@gmail.com>
7 tasks
nateberkopec
pushed a commit
that referenced
this pull request
Aug 22, 2022
* Fail hard if SSL certs or keys cannot be read by user Previously if an SSL cert or key could not be read, Puma would bind to the configured SSL port but not accept any connections. The only indication that something went awry is an obscure log message: ``` #<Puma::MiniSSL::SSLError: OpenSSL error: error:1417A0C1:SSL routines:tls_post_process_client_hello:no shared cipher - 193> ``` We now fail hard with an exception if this happens to make it clear that the permissions need to be fixed. Relates to #1339 * minissl.rb - add check_file method Co-authored-by: MSP-Greg <Greg.mpls@gmail.com>
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Fail hard if SSL certs or keys cannot be read by user Previously if an SSL cert or key could not be read, Puma would bind to the configured SSL port but not accept any connections. The only indication that something went awry is an obscure log message: ``` #<Puma::MiniSSL::SSLError: OpenSSL error: error:1417A0C1:SSL routines:tls_post_process_client_hello:no shared cipher - 193> ``` We now fail hard with an exception if this happens to make it clear that the permissions need to be fixed. Relates to puma#1339 * minissl.rb - add check_file method Co-authored-by: MSP-Greg <Greg.mpls@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously if an SSL cert or key could not be read, Puma would bind to
the configured SSL port but not accept any connections. The only
indication that something went awry is an obscure log message:
We now fail hard with an exception if this happens to make it clear
that the permissions need to be fixed.
Relates to #1339
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.