Supporting Custom Logger Class

[jchristie55332]

Is your feature request related to a problem? Please describe.

It is possible to have custom loggers that allow for json log aggregation as well as formatting and custom attributes.

Without json log aggregation results in poorly formatted logs and duplication of log formatting rules.

Describe the solution you'd like

It would be great to pass a custom logging class to puma that would then be logged to.

I would expect this to result in a new method in the DSL.

[nateberkopec]

Does log_formatter do what you want?

e.g.

log_formatter do |str|
  "[#{Process.pid}] [#{Socket.gethostname}] #{Time.now}: #{str}"
end

[jchristie55332]

Does log_formatter do what you want?

e.g.

log_formatter do |str|
  "[#{Process.pid}] [#{Socket.gethostname}] #{Time.now}: #{str}"
end

No. Using log_formatter still results in the formatted string being output to STDOUT.

I suggest that we support the use of a custom logger for outputting of log lines

puma/lib/puma/events.rb

Lines 62 to 69 in 503b1cd

	# Write +str+ to +@stdout+
	#
	def log(str)
	@stdout.puts format(str) if @stdout.respond_to? :puts
	@stdout.flush unless @stdout.sync
	rescue Errno::EPIPE
	end

I was also thinking that we could include for the ErrorLogger

[kuei0221]

How about stdout_redirect ? It will save the STDOUT to the file you want.

puma/lib/puma/dsl.rb

Lines 388 to 399 in 503b1cd

	# Redirect +STDOUT+ and +STDERR+ to files specified. The +append+ parameter
	# specifies whether the output is appended, the default is +false+.
	#
	# @example
	# stdout_redirect '/app/lolcat/log/stdout', '/app/lolcat/log/stderr'
	# @example
	# stdout_redirect '/app/lolcat/log/stdout', '/app/lolcat/log/stderr', true
	def stdout_redirect(stdout=nil, stderr=nil, append=false)
	@options[:redirect_stdout] = stdout
	@options[:redirect_stderr] = stderr
	@options[:redirect_append] = append
	end

[alexeevit]

So, do you expect to use it like something like this?

# config/puma.rb
...
custom_logger_class CustomLogger
...

# custom_logger.rb
class CustomLogger
  def call(level, message)
    ...
  end
end

[nateberkopec]

Generally with a custom logger I would expect a config interface like:

logger Logger.new(STDOUT)

[svoop]

For reference, the interface is a little different from what @nateberkopec has suggested:

custom_logger Logger.new(STDOUT)