Fix TestDestroySetsEncryptionsalt test and resulting bug #15432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-02-15)Bug Fixes
|
Frassle
force-pushed
the
fixTestDestroySetsEncryptionsalt
branch
from
3f3fe8a
to
00107c2
Compare
julienp
approved these changes
Feb 15, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
### Features - [components] Component providers can return output values in their response to the engine. [#15408](#15408) - [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for resources and local variables [#15419](#15419) - [sdk/{nodejs,python}] Publish dev versions of the nodejs and python SDKs ### Bug Fixes - [cli] Fix `pulumi destroy` to fill in stack config with the secret config from state, not fresh secret config. [#15432](#15432) - [engine] Engine no longer assumes program dependencies are specified as semantic versions. [#15409](#15409) - [components/go] Component providers now correctly return output values to the engine. [#15405](#15405) ### Miscellaneous - [protobuf] Split CallRequest into ResourceCallRequest for the ResourceMonitor service. [#15404](#15404) - [backend/diy] Add a warning that non-project mode will be deprecated at some point. [#15411](#15411)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on some other secret manager changes I found that
TestDestroySetsEncryptedkeywasn't actually fully testing what we thought it was.Firstly it was a bad name, we're checking for
encryptionsaltbeing set notencryptedkey. But more importantly it wasn't checking that the salt stayed the same.Turned out
destroywas loading the stack config, seeing noencryptionsaltand so new'ing up a brand new passphrase secret manager and state and then saving that to the stack config.This is now fixed that the test asserts that the salt is exactly what's expected and I've fixed up the engine code to do this correctly.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change