Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about non-project mode #15411

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Warn about non-project mode #15411

merged 1 commit into from
Feb 13, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Feb 8, 2024

Description

In preparation for deprecating non-project mode at some point. This is phase 1 of encouraging users off of legacy mode.

Any time a user opens a backend in legacy mode (either old states, or new states with DIY_BACKEND_LEGACY_LAYOUT set) we'll warn that non-project mode is due to deprecate this year.

They can disable this warning by setting PULUMI_DIY_BACKEND_ACKNOWLEDGE_LEGACY_WARNING to true.

The next phase (in a few months) will turn this into an error which they'll be able to opt out of by setting PULUMI_DIY_BACKEND_ACKNOWLEDGE_LEGACY_ERROR to true.

After that it will be a hard error and all non-project related code will be removed.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

In preperation for deprecating non-project mode at some point. This is
phase 1 of encouraging users off of legacy mode.

Any time a user opens a backend in legacy mode (either old states, or
new states with DIY_BACKEND_LEGACY_LAYOUT set) we'll warn that
non-project mode is due to deprecate this year.

They can disable this warning by setting
PULUMI_DIY_BACKEND_ACKNOWLEDGE_LEGACY_WARNING to true.

The next phase (in a few months) will turn this into an error which
they'll be able to opt out of by setting
PULUMI_DIY_BACKEND_ACKNOWLEDGE_LEGACY_ERROR to true.

After that it will be a hard error and all non-project related code will
be removed.
@Frassle Frassle requested a review from a team February 8, 2024 20:39
@Frassle Frassle marked this pull request as ready for review February 8, 2024 20:39
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2024-02-08)

Miscellaneous

  • [backend/diy] Add a warning that non-project mode will be deprecated at some point.
    #15411

@Frassle Frassle added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 038ea95 Feb 13, 2024
46 checks passed
@Frassle Frassle deleted the fraser/deprecateNonProjectMode branch February 13, 2024 09:17
github-merge-queue bot pushed a commit that referenced this pull request Feb 15, 2024
### Features

- [components] Component providers can return output values in their
response to the engine.

- [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for
resources and local variables
  [#15419](#15419)


### Bug Fixes

- [engine] Engine no longer assumes program dependencies are specified
as semantic versions.
  [#15409](#15409)

- [components/go] Component providers now correctly return output values
to the engine.
  [#15405](#15405)


### Miscellaneous

- [protobuf] Split CallRequest into ResourceCallRequest for the
ResourceMonitor service.
  [#15404](#15404)

- [backend/diy] Add a warning that non-project mode will be deprecated
at some point.
  [#15411](#15411)
@justinvp justinvp mentioned this pull request Feb 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 16, 2024
### Features

- [components] Component providers can return output values in their
response to the engine.
  [#15408](#15408)

- [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for
resources and local variables
  [#15419](#15419)

- [sdk/{nodejs,python}] Publish dev versions of the nodejs and python
SDKs


### Bug Fixes

- [cli] Fix `pulumi destroy` to fill in stack config with the secret
config from state, not fresh secret config.
  [#15432](#15432)

- [engine] Engine no longer assumes program dependencies are specified
as semantic versions.
  [#15409](#15409)

- [components/go] Component providers now correctly return output values
to the engine.
  [#15405](#15405)


### Miscellaneous

- [protobuf] Split CallRequest into ResourceCallRequest for the
ResourceMonitor service.
  [#15404](#15404)

- [backend/diy] Add a warning that non-project mode will be deprecated
at some point.
  [#15411](#15411)
Frassle added a commit that referenced this pull request Feb 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
This reverts commit 038ea95.

---------

Co-authored-by: Justin Van Patten <jvp@justinvp.com>
@klyse
Copy link

klyse commented Feb 23, 2024

I'm getting this error/warning message now when calling <workspace>.UpAsync using the C# Pulumi Automation API, and I struggle to understand what the planned change is, what will be deprecated exactly, and how I can migrate to the new "project" mode. Do you maybe have some some docs on this?

@tgummerer
Copy link
Collaborator

@klyse We actually decided to not go ahead with this, and reverted this change, so the warning should go away in the next release. Sorry about the confusion here.

If you're still curious, here's the blog introducing Projects for DIY (formerly self-managed) backends: https://www.pulumi.com/blog/project-scoped-stacks-in-self-managed-backend/. The idea was to make projects mode the only mode and deprecating non-project mode, but we decided to keep supporting non-project mode after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants