Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for legacy style names #15384

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add test for legacy style names #15384

merged 1 commit into from
Feb 15, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Feb 6, 2024

Long term I want to introduce a new snake_case based naming system to schemas. There's an internal design doc about this at https://docs.google.com/document/d/1ns07htpLjw0dJPn5p7TBPVULvwwYc1Pl7l1c1jdGXoY/edit.

As part of that we get the nice feature that nearly all current names are either valid and the same in both system (e.g. "foo"), or they look different in the current system (e.g. "fooBar"). But there are a handful of odd cases where we have providers using names that look like they should be new style snake case names (e.g. kubernetes has a load of "x_kubernetes_" properties).

To provide a way to ensure k8s can stay on the current name generation (even though it gives pretty odd results) this change adds a test with a schema demonstrating a load of snake_case names. When we do add the new naming system this test should not diff, excepting possibly setting an option if the new naming system is opt-out rather than opt-in.

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Feb 6, 2024

Changelog

[uncommitted] (2024-02-15)

@Frassle Frassle added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 6, 2024
@Frassle Frassle force-pushed the fraser/legacyNames branch 3 times, most recently from e7a98bf to 8b0b6ae Compare February 6, 2024 16:33
@Frassle Frassle requested a review from a team February 6, 2024 21:25
@Frassle Frassle marked this pull request as ready for review February 6, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants