-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for legacy style names #15384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-02-15) |
This was referenced Feb 6, 2024
Test: Upgrade pulumi/{pkg,sdk} to e173d85828371d4d2c2118bb33dc7f9516d48bcc
pulumi/pulumi-azuread#786
Closed
Closed
Closed
Closed
Frassle
added
the
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
label
Feb 6, 2024
Frassle
force-pushed
the
fraser/legacyNames
branch
3 times, most recently
from
February 6, 2024 16:33
e7a98bf
to
8b0b6ae
Compare
This was referenced Feb 6, 2024
Closed
Test: Upgrade pulumi/{pkg,sdk} to 8b0b6ae2024074bc0fea2089d409df0a90a0e2a6
pulumi/pulumi-azuread#788
Closed
Closed
Closed
This was referenced Feb 6, 2024
justinvp
approved these changes
Feb 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 15, 2024
Frassle
force-pushed
the
fraser/legacyNames
branch
from
February 15, 2024 11:21
8b0b6ae
to
abf0ea7
Compare
This was referenced Feb 15, 2024
Closed
Test: Upgrade pulumi/{pkg,sdk} to abf0ea74bc11e99cf509134086b6667a52297841
pulumi/pulumi-azuread#807
Closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 15, 2024
Frassle
force-pushed
the
fraser/legacyNames
branch
from
February 15, 2024 13:25
abf0ea7
to
26dbda6
Compare
This was referenced Feb 15, 2024
Closed
Test: Upgrade pulumi/{pkg,sdk} to 26dbda694fbe0f21d3e02ec9d880840b8440d16e
pulumi/pulumi-azuread#808
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long term I want to introduce a new snake_case based naming system to schemas. There's an internal design doc about this at https://docs.google.com/document/d/1ns07htpLjw0dJPn5p7TBPVULvwwYc1Pl7l1c1jdGXoY/edit.
As part of that we get the nice feature that nearly all current names are either valid and the same in both system (e.g. "foo"), or they look different in the current system (e.g. "fooBar"). But there are a handful of odd cases where we have providers using names that look like they should be new style snake case names (e.g. kubernetes has a load of "x_kubernetes_" properties).
To provide a way to ensure k8s can stay on the current name generation (even though it gives pretty odd results) this change adds a test with a schema demonstrating a load of snake_case names. When we do add the new naming system this test should not diff, excepting possibly setting an option if the new naming system is opt-out rather than opt-in.