Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly SDK generation fails in "Cleanup SDK Folder" #1982

Closed
thomas11 opened this issue Sep 20, 2022 · 0 comments · Fixed by #1983
Closed

Nightly SDK generation fails in "Cleanup SDK Folder" #1982

thomas11 opened this issue Sep 20, 2022 · 0 comments · Fixed by #1983
Assignees
@thomas11
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@thomas11
Copy link
Contributor

What happened?

Example

Steps to reproduce

observe nightly-sdk-generation runs on Github

Expected Behavior

success

Actual Behavior

Failure in make clean due to bin directory not found

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@thomas11 thomas11 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 20, 2022
@thomas11 thomas11 self-assigned this Sep 20, 2022
@thomas11 thomas11 removed the needs-triage Needs attention from the triage team label Sep 20, 2022
thomas11 added a commit that referenced this issue Sep 20, 2022
@thomas11
Fix make clean in case 'bin' dir doesn't exist yet #1982
7c015a7
thomas11 added a commit that referenced this issue Sep 20, 2022
@thomas11
Don't fail initial commit if there's nothing to commit #1982
52c5108
thomas11 added a commit that referenced this issue Sep 20, 2022
@thomas11
Revert "Don't fail initial commit if there's nothing to commit #1982"
6f87bce 
This reverts commit 52c5108.
thomas11 added a commit that referenced this issue Sep 21, 2022
@thomas11
Fetch git tags for pulumictl #1982
aa27499
thomas11 added a commit that referenced this issue Sep 21, 2022
@thomas11
Fetch git tags via fetch-depth instead #1982
54e94a1
@thomas11 thomas11 linked a pull request Sep 21, 2022 that will close this issue
Fix nightly-sdk-generation #1983
Merged
thomas11 added a commit that referenced this issue Sep 21, 2022
@thomas11
Fix nightly-sdk-generation (#1983)
b4f4636 
* Fix make clean in case 'bin' dir doesn't exist yet #1982

* Cleanup step should remove the whole SDKs

* Fetch git tags for pulumictl #1982

* Fetch git tags via fetch-depth instead #1982
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas11 thomas11

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nightly-sdk-generation pulumi/pulumi-azure-native
2 participants
@thomas11 @pulumi-bot