Remove remove-ephemeral-resources.patch #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guineveresaenger
force-pushed
the
guin/remove-write-only-patch
branch
from
a4343d5 to
e21aa4e
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5339 +/- ##
==========================================
- Coverage 24.36% 24.31% -0.05%
==========================================
Files 364 364
Lines 145472 145577 +105
==========================================
- Hits 35448 35401 -47
- Misses 109925 110077 +152
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t0yv0
reviewed
Mar 19, 2025
| func(propertyVisitInfo tfbridge.PropertyVisitInfo) (tfbridge.PropertyVisitResult, error) { | ||
| schemaPath := propertyVisitInfo.SchemaPath() | ||
| if key, ok := schemaPath[len(schemaPath)-1].(walk.GetAttrStep); ok { | ||
| if strings.Contains(key.Name, "_wo_") || strings.HasSuffix(key.Name, "_wo") { |
There was a problem hiding this comment.
I like this, this seems reasonable. If we are worried that this will over-eagerly skip a property that does not need skipping, we can add a file with a checklist of removed properties, say (resource, SchemaPath) pairs and force PRs to change that, perhaps in a test.
t0yv0
reviewed
Mar 19, 2025
| @@ -1,1002 +0,0 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: guineveresaenger <guinevere@pulumi.com> | |||
|
This PR has been shipped in release v6.73.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request combines new bridge functionality and an attribute traversal to automate omitting any of the kind of write-only and write-only-adjacent resources that a patch addressed previously.
While there's a bit of metadata tracking cruft due to the attribute traversal wanting build-time information, the schema itself has no changes.
Fixes #5231.