Skip to content

get_file_url should support both token manager token and auth key like other endpoints #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abdalla-nayer opened this issue Nov 25, 2022 · 2 comments · Fixed by #305
Closed

get_file_url should support both token manager token and auth key like other endpoints #302

abdalla-nayer opened this issue Nov 25, 2022 · 2 comments · Fixed by #305
Labels
status: done This issue is considered resolved.

Comments

@abdalla-nayer
Copy link

abdalla-nayer commented Nov 25, 2022 •
edited
Loading

Problem
1- We are using access manager
2- Uploading image is working
2- While getFileUrl returns 403 as auth query param is missing from the URL

image

Request URL: http://ps1.pndsn.com/v1/files/sub-c-63321534-3032-46d3-af6f-74f7903e3dff/channels/7c0c5ea3-5290-4635-9add-db52305ce8db-team-team-10407-7c0c5ea3-5290-4635-9add-db52305ce8db/files/3f5f57df-10b5-49d8-b898-9276c81bda16/5ab4d4ac2000007d06eb2c56.jpeg?uuid=7c0c5ea3-5290-4635-9add-db52305ce8db-abdallanayer0754&pnsdk=PubNub-JS-Web%2F7.2.0%20RCC%2F0.13.0
Request Method: GET
Status Code: 403 Forbidden

while other endpoints have an isAuthSupported flag, getFileUrl is not an endpoint and it doesnot have isAuthSupported flag

Desired Solution:
getFileUrl should work with the access manager as other endpoints do example (generate_upload_url)
abdalla-nayer added a commit to abdalla-nayer/pubnub-fix-302 that referenced this issue Nov 25, 2022
@abdalla-nayer
Fixing issue pubnub#302
339b4f8 
get_file_url should support both token manager token and auth key l
abdalla-nayer added a commit to abdalla-nayer/pubnub-fix-302 that referenced this issue Nov 25, 2022
@abdalla-nayer
Fixing issue pubnub#302
538951c 
get_file_url should support both token manager token and auth key
@abdalla-nayer
Copy link
Author

Created a PR to fix this issue #303

This was referenced Dec 7, 2022
Closed
Merged
@are are closed this as completed in #305 Dec 13, 2022
@pubnub-release-bot
Copy link
Contributor

@abdalla-nayer this issue is addressed in v7.2.2

@github-actions github-actions bot added the status: done This issue is considered resolved. label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: done This issue is considered resolved.
Projects
None yet
Milestone
No milestone
2 participants
@abdalla-nayer @pubnub-release-bot