Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log v0.4.19 increased its MSRV to Rust 1.60 #850

Closed
psychon opened this issue Jul 1, 2023 · 1 comment · Fixed by #851
Closed

log v0.4.19 increased its MSRV to Rust 1.60 #850

psychon opened this issue Jul 1, 2023 · 1 comment · Fixed by #851

Comments

@psychon
Copy link
Owner

psychon commented Jul 1, 2023

Our monthly automatic CI just failed to build x11rb-async: https://github.com/psychon/x11rb/actions/runs/5428169003/jobs/9872128038

In the previous CI run (that worked fine), log was at version 0.4.18. See the long discussions in log for details (they were able to get rid of a build.rs script which helps build times across the ecosystem):

x11rb-async indirectly depends on log through several paths:

  • async-io -> log = "0.4.11" (but that was replaced by notgull with tracing in master: smol-rs/async-io@a1f4c0a because async)
  • async-io -> polling -> log = "0.4.11" (also replaced with tracing by notgull in master: smol-rs/polling@7a1fd31 because async)
  • blocking -> log = "0.4.17" (also replaced with tracing by notgull in master: smol-rs/blocking@1e835fb because async`)
  • (dev-dependency) tracing-subscriber -> tracing-log -> log = "0.4" (ha! not switched over by notgull (obviously))

So.... Options?

  1. just wait this out. Eventually, log will become just a dev-dependency since notgull switched everything to tracing. Since the msrv-check only builds the lib, I think at that point CI should fix itself. Thanks notgull. Now please magically bring us new releases of everything to fix CI. ;-)
  2. figure out pinning in CI (I actually don't know how to do that)
  3. bump the MSRV (of "everything"? of just x11rb-async?)
@psychon
Copy link
Owner Author

psychon commented Jul 1, 2023

figure out pinning in CI (I actually don't know how to do that)

Doesn't seem to be as hard as I thought. Locally, running cargo update --package log --precise 0.4.18 seems to do the job. I guess I'll have to try this in CI.

psychon added a commit that referenced this issue Jul 1, 2023
log 0.4.19 increased its MSRV to Rust 1.60, which is higher than our
MSRV of 1.56. Thus, pin log 0.4.18 in our msrv-check CI build.

Fixes: #850
Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant