Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PEP 696 #4327

Merged
merged 5 commits into from Apr 24, 2024
Merged

Support PEP 696 #4327

merged 5 commits into from Apr 24, 2024

Conversation

JelleZijlstra
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited

diff-shades reports zero changes comparing this PR (57fe1e1) to main (2f88085).

What is this? | Workflow run | diff-shades documentation

hauntsaninja
hauntsaninja reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some more test cases. These may be preexisting, but:

  • I think I'd prefer if simple / longer split the arguments instead of the generic part.
  • The formatting in trailing_comma2 looks buggy to me

hauntsaninja
hauntsaninja approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have an issue for those too :-)

@JelleZijlstra
Copy link
Collaborator Author

Yes, #4071 for reference.

@hauntsaninja hauntsaninja merged commit 3f0f8f1 into psf:main Apr 24, 2024
45 checks passed
@JelleZijlstra JelleZijlstra deleted the pep696 branch April 24, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JelleZijlstra @hauntsaninja