Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to old flake8-bugbear #4319

Merged
merged 1 commit into from Apr 22, 2024
Merged

Pin to old flake8-bugbear #4319

merged 1 commit into from Apr 22, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Apr 22, 2024
@hauntsaninja hauntsaninja merged commit 7669381 into psf:main Apr 22, 2024
44 checks passed
@hauntsaninja hauntsaninja deleted the fix-bugbear branch April 22, 2024 03:19
@cooperlees
Copy link
Collaborator

cooperlees commented Apr 22, 2024 •
edited

We could have just disabled B909 right?

@hauntsaninja
Copy link
Collaborator Author

That would have worked! But B909 is a useful check and I think the new behaviour is just buggy (unless there's something I don't understand). Also pinning here seems fine... main breaking was confusing for the folks in #4318 and we pin several other deps in pre-commit / have the autoupdate thing.

But obviously will do whatever you suggest here, just let me know :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hauntsaninja @cooperlees