Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trailing comma logic more consise #4202

Merged
merged 9 commits into from Feb 28, 2024
Merged

Make trailing comma logic more consise #4202

merged 9 commits into from Feb 28, 2024

Conversation

RedGuy12
Copy link
Contributor

@RedGuy12 RedGuy12 commented Feb 1, 2024

Description

Simplified the logic for adding trailing commas. Turned out it was actually a bit simpler than I thought.
See #4164 (comment)

Checklist - did you ...

  • [-] Add an entry in CHANGES.md if necessary?
  • [-] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

RedGuy12 and others added 3 commits February 1, 2024 10:26
@RedGuy12
Make trailing comma logic more consise
014ee6f 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
40eda29 
for more information, see https://pre-commit.ci
@RedGuy12
fix: forgotten import
26f912f 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12 RedGuy12 marked this pull request as draft February 1, 2024 16:39
@RedGuy12 RedGuy12 marked this pull request as ready for review February 1, 2024 16:56
@RedGuy12
fix: other forgotten import
00593d2 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited

diff-shades reports zero changes comparing this PR (8e160a6) to main (8990023).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra
JelleZijlstra reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nits

src/black/linegen.py Outdated Show resolved Hide resolved
src/black/nodes.py Outdated Show resolved Hide resolved
hauntsaninja
hauntsaninja approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again! :-)

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Feb 28, 2024
@hauntsaninja hauntsaninja merged commit d0287e1 into psf:main Feb 28, 2024
46 of 47 checks passed
@RedGuy12 RedGuy12 deleted the refactor-trailing-comma-logic branch February 28, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RedGuy12 @JelleZijlstra @hauntsaninja