Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore node_modules (produced by a pre-commit check) #4184

Merged
merged 1 commit into from Jan 28, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jan 28, 2024

Description

This directory gets created by a pre-commit check (prettier, probably), so adding it to the ignores.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

(I don't think any of these are needed for this change?)

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Jan 28, 2024
@JelleZijlstra
Copy link
Collaborator

Nice consequence is that if I merge this I don't have to approve CI for you any more :)

@JelleZijlstra JelleZijlstra merged commit 79fc115 into psf:main Jan 28, 2024
35 of 36 checks passed
@henryiii henryiii deleted the henryiii/chore/nodemodules branch January 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants