Preview style: Don't collapse dummy implementation with comment

[JelleZijlstra]

I found this change in our test suite while trying to stabilize the preview style:

 match command.split():
     case ["north"] | ["go", "north"]:
         current_room = current_room.neighbor("north")
-    case ["get", obj] | ["pick", "up", obj] | ["pick", obj, "up"]:
-        ...  # Code for picking up the given object
+    case (
+        ["get", obj] | ["pick", "up", obj] | ["pick", obj, "up"]
+    ): ...  # Code for picking up the given object

This is from the dummy_implementation preview change, #3796.

I think the new code looks worse here; we shouldn't use the dummy_implementation branch if there is a comment after the ellipsis.

[JelleZijlstra]

I tried to change this but it causes some problems in typeshed:

-    def __mul__(cls: type[_CT], other: int) -> type[Array[_CT]]: ...  # type: ignore[misc]  # pyright: ignore[reportGeneralTypeIssues]
-    def __rmul__(cls: type[_CT], other: int) -> type[Array[_CT]]: ...  # type: ignore[misc]  # pyright: ignore[reportGeneralTypeIssues]
+    def __mul__(cls: type[_CT], other: int) -> type[Array[_CT]]:
+        ...  # type: ignore[misc]  # pyright: ignore[reportGeneralTypeIssues]
+
+    def __rmul__(cls: type[_CT], other: int) -> type[Array[_CT]]:
+        ...  # type: ignore[misc]  # pyright: ignore[reportGeneralTypeIssues]

Will have to think more about the right approach here.

Also considering to turn off the dummy_implementations change for suites that aren't functions or classes.

[hauntsaninja]

Yeah, let's avoid changing the logic with comments. Only doing dummy impls for classes and functions seems like a good way to fix the issue.

[JelleZijlstra]

Sounds good, I updated the PR to apply the dummy impl logic only to classes and functions.