Preview: Keep requiring two empty lines between module-level docstring and first function or class definition. #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st function or class definition. Fixes psf#4027.
|
diff-shades results comparing this PR (61d8400) to main (9e3daa1). The full diff is available in the logs under the "Generate HTML diff report" step. |
hauntsaninja
approved these changes
Nov 6, 2023
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Nov 15, 2023
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0 yet, I'm waiting for psf#4012 to be merged as Pyink has local patches related by hugging parens. PiperOrigin-RevId: 582472645
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Nov 15, 2023
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. PiperOrigin-RevId: 582472645
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Nov 15, 2023
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. Also added two missing patches. PiperOrigin-RevId: 582472645
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Nov 15, 2023
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. Also added two missing patches. PiperOrigin-RevId: 582704838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4027.
Description
Checklist - did you ...
CHANGES.mdif necessary?