Move Docker image to hatch + compile #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move to hatch to build wheel - Install wheel into venv we copy with colorama + d Fixes #3928 Test: - See we can get black to execute: TODO: Update when compiled is working ``` crl-m1:black cooper$ docker run --rm black_compiled black --version black, 23.10.1.dev1+g882d879.d20231022 (compiled: no) Python (CPython) 3.11.6 ``` - Check size: TODO: Update when compiled ``` crl-m1:black cooper$ docker image ls | grep black_compiled black_compiled latest 9db38fb7f1d0 4 minutes ago 180MB ```
cooperlees
force-pushed
the
compile_docker
branch
from
3d7044d
to
b44c0e6
Compare
…pip install - Also install uvloop
cooperlees
added
C: packaging
cooperlees
force-pushed
the
compile_docker
branch
from
2d56286
to
9f96531
Compare
|
I expect no little size regression as I just built locally from main: It's 4mb larger, so when docker hub strips fat + compress on upload it should be same-ish. Which is good. |
JelleZijlstra
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3928
Test:
docker build -t black_compiled .