Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2213] Add support for single line format skip with other comments on the same line #3959

Merged
merged 13 commits into from Oct 25, 2023
Merged

[2213] Add support for single line format skip with other comments on the same line #3959

merged 13 commits into from Oct 25, 2023

Conversation

henriholopainen
Copy link
Contributor

@henriholopainen henriholopainen commented Oct 20, 2023 •
edited

Description

As requested here, this PR implements support for single line format skip with other comments on the same line. A question for the reviewer: should this be a preview style feature?

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited

diff-shades reports zero changes comparing this PR (1433c93) to main (1d4c31a).

What is this? | Workflow run | diff-shades documentation

@henriholopainen
Copy link
Contributor Author

At least #3330 also relates to this

@henriholopainen henriholopainen changed the title [2213] Add support for single line format skip with other pragmas on the same line [2213] Add support for single line format skip with other comments on the same line Oct 20, 2023
@JelleZijlstra JelleZijlstra self-requested a review October 20, 2023 18:02
JelleZijlstra
JelleZijlstra reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yes, this should be preview style only.

docs/the_black_code_style/current_style.md Show resolved Hide resolved
JelleZijlstra
JelleZijlstra reviewed Oct 24, 2023
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
docs/the_black_code_style/current_style.md Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 878937b into psf:main Oct 25, 2023
40 of 41 checks passed
@dwyatte dwyatte mentioned this pull request Nov 7, 2023
Closed
@hauntsaninja hauntsaninja mentioned this pull request Nov 13, 2023
Closed
@konstin konstin mentioned this pull request Nov 14, 2023
Closed
28 tasks
This was referenced Nov 28, 2023
Closed
Closed
@m-czernek m-czernek mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henriholopainen @JelleZijlstra