Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary parameter to action #3958

Merged
merged 3 commits into from Oct 23, 2023
Merged

Add summary parameter to action #3958

merged 3 commits into from Oct 23, 2023

Conversation

dariocurr
Copy link
Contributor

@dariocurr dariocurr commented Oct 19, 2023

Description

I would like to be able to suppress the github workflow summary output. To be able to do that I added a parameter

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

I did not added anything because I didn't find neither documentation or tests regarding the action (I had a quick look, please help me find them if I am wrong)

@dariocurr
Copy link
Contributor Author

dariocurr commented Oct 23, 2023

I have no idea about the failing checks

@JelleZijlstra
Copy link
Collaborator

@dariocurr there are two failing checks:

  • One for a missing entry in CHANGES.md. You should add one, under the "Integrations" section, to communicate to users what changed.
  • One for the Windows build. This has been failing continuously for unknown reasons; you can ignore it for now.

@dariocurr
Copy link
Contributor Author

@dariocurr there are two failing checks:

  • One for a missing entry in CHANGES.md. You should add one, under the "Integrations" section, to communicate to users what changed.
  • One for the Windows build. This has been failing continuously for unknown reasons; you can ignore it for now.

Added it

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit a7643fa into psf:main Oct 23, 2023
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants