Preview style wraps long unbreakable strings differently based on whether the LHS has an annotation

[yilei]

Black v23.10.0

Playground link

Options

--line-length=88
--safe
--preview

Input

class A:
    attr1: str = 'this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long'
    attr2 = 'this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long'

Output

class A:
    attr1: str = (
        "this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long"
    )
    attr2 = "this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long"

Expected

class A:
    attr1: str = "this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long"
    attr2 = "this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long_this_is_very_very_long"

Since the string wrapped in parens still can't fit in the line-length, Black won't wrap.

Did a git-bisect and this behavior was introduced in #3899, and it doesn't seem to be an intentional change from that PR.

[jakkdl]

Heya, author of #3899 here.

The behaviour makes sense to me, since the type could also be long.

class A:
    attr1: my_long_very_custom_type_bla_bla_bla = "111111111111111111111111111111111111111111111111111111"

makes sense to me to break, even if the string can't be fit inside the line length.

Can confirm I didn't explicitly think about this case - but am not surprised that this behavior got changed since it did mess around with line-wrapping and type hints. But I'm not really against this behavior getting reverted.