Black puts "pyright: ignore" comments on the wrong line

[RobinFrcd]

Hi,
I've switched to VS code and pyright recently, and I realized black is breaking a lot of # pyright: ignore comments.

Input (both are valid for pyright):

asm_client: SecretsManagerClient = boto3.client("secretsmanager") # pyright: ignore[reportUnknownMemberType]
asm_client: SecretsManagerClient = boto3.client( # pyright: ignore[reportUnknownMemberType]
    "secretsmanager"
)  

Output:

asm_client: SecretsManagerClient = boto3.client(
    "secretsmanager"
)  # pyright: ignore[reportUnknownMemberType]
asm_client: SecretsManagerClient = boto3.client(
    "secretsmanager"
)  # pyright: ignore[reportUnknownMemberType]

Is there a way to stick the pyright comment to the original line ?

I'm using:

black, 23.9.1 (compiled: yes)
Python (CPython) 3.11.6

Thanks

[JelleZijlstra]

See also #3661.

I think this is inherently impossible to solve in all cases, because if Black splits a line, it has no way to know which part of the line the ignore comment should apply to. However, we could probably come up with a better heuristic, like putting the comment on the first rather than the last line.

[henriholopainen]

When/if this gets merged, one option would be:

asm_client: SecretsManagerClient = boto3.client("secretsmanager")  # fmt: skip; pyright: ignore[reportUnknownMemberType]

[JelleZijlstra]

Pyright doesn't support that syntax though. (Maybe it should, but that's not a question for this tracker.)